Defining enum case with a class constant causes a crash

[jack-worman]

https://psalm.dev/r/224fdb8a5d

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/224fdb8a5d

<?php

enum AppEnvs: string
{
    case Development = Environments::DEV;
    case Production = Environments::PROD;
    case Testing = Environments::TEST;
}

class Environments {
    public const DEV = 'dev';
    public const PROD = 'prod';
    public const TEST = 'test';
}

Psalm encountered an internal error:

/vendor/vimeo/psalm/src/Psalm/Internal/PhpVisitor/Reflector/ClassLikeNodeScanner.php: Failed to infer case value for Development

[jack-worman]

It seems to be because in SimpleTypeInferer::infer():

                if ($existing_class_constants === null
                    && $file_source instanceof StatementsAnalyzer
                ) {
                    try {
                        $foreign_class_constant = $codebase->classlikes->getClassConstantType(
                            $const_fq_class_name,
                            $stmt->name->name,
                            ReflectionProperty::IS_PRIVATE,
                            $file_source,
                        );

                        if ($foreign_class_constant) {
                            return $foreign_class_constant;
                        }

                        return null;
                    } catch (InvalidArgumentException | CircularReferenceException $e) {
                        return null;
                    }
                }
            }

$file_source instanceof StatementsAnalyzer returns false.

[weirdan]

$file_source instanceof StatementsAnalyzer returns false.

That's because we're trying to infer values in the scanning phase. When that fails, we need to store UnresolvedConstantComponent instead and resolve it later in the analysis phase (when all classlikes are already loaded) rather than throwing an exception.

[DmytroPolavis]

Hey, any update on this? Having a similar issue, and what is more frustrating is that directive does not work for a file with such error :(