psalm insists that printf() needs at least two arguments

[pilif]

https://psalm.dev/r/fbda7f627d

this is totally valid code. Now granted, echo could have been used, but it's totally valid.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/fbda7f627d

<?php

printf("a");

Psalm output (using commit 8d1876a):

ERROR: TooFewArguments - 3:1 - Too few arguments for printf, expecting at least 2 arguments

[kkmuffme]

Yeah that was kind of the point tbh, but it is just a side-effect of sprintf being analyzed (since sprintf without 2 args makes no sense, just save the sprintf call)

I'll fix this quickly

[kkmuffme]

@orklah sorry to reopen this, but I think this error makes sense actually.

Practically, using printf is fine, however this usually indicates a bug/something was forgotten when refactoring the code. If you really use printf with only 1 arg, you should rather use print() (or echo) instead of printf.

Could you revert the merged #9993 ?

[orklah]

Well, in principle I'd disagree (evidence A: an issue has been open days after release on that topic)

However, it seems master still emits an issue for that snippet saying that there is no placeholder in the first arg. So we're kinda in a middle ground

It would be better if it had a specific issue to be help ignore this issue for people that uses printf that way but the current issue is explicit enough to help find a potential issue