Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use branch name to randomize tests to ensure test dependencies will error #10424

Merged

Conversation

kkmuffme
Copy link
Contributor

@kkmuffme kkmuffme commented Nov 29, 2023

Tests were run randomized in the same order in all cases, which could hide dependency issues between tests.
Changed so tests will randomize using the PR branch name instead of a static string. Like that the tests will stay in the same ordering for a given PR, but each PR has them ordered in another, random way, ensuring any problematic test dependencies will at least report eventually with subsequent PRs.

@kkmuffme kkmuffme marked this pull request as ready for review November 29, 2023 08:13
@kkmuffme
Copy link
Contributor Author

@orklah please merge

@orklah orklah added the release:internal The PR will be included in 'Internal changes' section of the release notes label Nov 29, 2023
@orklah orklah merged commit f9f8bac into vimeo:5.x Nov 29, 2023
49 of 50 checks passed
@orklah
Copy link
Collaborator

orklah commented Nov 29, 2023

Thanks!

tcarrio referenced this pull request in open-feature/php-sdk Dec 4, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [vimeo/psalm](https://github.com/vimeo/psalm) | `~5.16.0` ->
`~5.17.0` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/vimeo%2fpsalm/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/vimeo%2fpsalm/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/vimeo%2fpsalm/5.16.0/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/vimeo%2fpsalm/5.16.0/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vimeo/psalm (vimeo/psalm)</summary>

### [`v5.17.0`](https://github.com/vimeo/psalm/releases/tag/5.17.0)

[Compare
Source](https://github.com/vimeo/psalm/compare/5.16.0...5.17.0)

<!-- Release notes generated using configuration in .github/release.yml
at 5.x -->

#### What's Changed

##### Features

- Implement by-ref closure use analysis by
[@&#8203;danog](https://github.com/danog) in
[https://github.com/vimeo/psalm/pull/10419](https://github.com/vimeo/psalm/pull/10419)

##### Fixes

- Update MongoDB stubs for 1.17 by
[@&#8203;alcaeus](https://github.com/alcaeus) in
[https://github.com/vimeo/psalm/pull/10402](https://github.com/vimeo/psalm/pull/10402)
- Fix backtick analysis by [@&#8203;danog](https://github.com/danog)
in
[https://github.com/vimeo/psalm/pull/10409](https://github.com/vimeo/psalm/pull/10409)
- Declare we do not support document highlighting by
[@&#8203;tm1000](https://github.com/tm1000) in
[https://github.com/vimeo/psalm/pull/10408](https://github.com/vimeo/psalm/pull/10408)
- update define types to be correct by
[@&#8203;kkmuffme](https://github.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/10423](https://github.com/vimeo/psalm/pull/10423)
- Fix return type of DOMXPath::query by
[@&#8203;nielsdos](https://github.com/nielsdos) in
[https://github.com/vimeo/psalm/pull/10443](https://github.com/vimeo/psalm/pull/10443)
- Fix CLI -r error by [@&#8203;kkmuffme](https://github.com/kkmuffme)
in
[https://github.com/vimeo/psalm/pull/10442](https://github.com/vimeo/psalm/pull/10442)
- Use correct file path while adding unused suppressions for virtual
\__… by [@&#8203;danog](https://github.com/danog) in
[https://github.com/vimeo/psalm/pull/10434](https://github.com/vimeo/psalm/pull/10434)
- Restore support for null coalesce on match expressions by
[@&#8203;tscni](https://github.com/tscni) in
[https://github.com/vimeo/psalm/pull/10422](https://github.com/vimeo/psalm/pull/10422)
- Fix static magic method pureness not being inherited from traits by
[@&#8203;tscni](https://github.com/tscni) in
[https://github.com/vimeo/psalm/pull/10429](https://github.com/vimeo/psalm/pull/10429)
- Fix POSIX only detection of absolute paths by
[@&#8203;rarila](https://github.com/rarila) in
[https://github.com/vimeo/psalm/pull/10441](https://github.com/vimeo/psalm/pull/10441)
- Emit UnusedPsalmSuppress issues for suppressed issues already removed
by [@&#8203;danog](https://github.com/danog) in
[https://github.com/vimeo/psalm/pull/10431](https://github.com/vimeo/psalm/pull/10431)
- Use keyed arrays when assigning literal union keys & assertion fixes
by [@&#8203;danog](https://github.com/danog) in
[https://github.com/vimeo/psalm/pull/10439](https://github.com/vimeo/psalm/pull/10439)

##### Internal changes

- use branch name to randomize tests to ensure test dependencies will
error by [@&#8203;kkmuffme](https://github.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/10424](https://github.com/vimeo/psalm/pull/10424)

#### New Contributors

- [@&#8203;nielsdos](https://github.com/nielsdos) made their first
contribution in
[https://github.com/vimeo/psalm/pull/10443](https://github.com/vimeo/psalm/pull/10443)

**Full Changelog**:
vimeo/psalm@5.16.0...5.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-feature/php-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
tcarrio referenced this pull request in open-feature/php-sdk Dec 5, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [vimeo/psalm](https://github.com/vimeo/psalm) | `~5.16.0` ->
`~5.17.0` |
[![age](https://developer.mend.io/api/mc/badges/age/packagist/vimeo%2fpsalm/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/packagist/vimeo%2fpsalm/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/packagist/vimeo%2fpsalm/5.16.0/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/packagist/vimeo%2fpsalm/5.16.0/5.17.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>vimeo/psalm (vimeo/psalm)</summary>

### [`v5.17.0`](https://github.com/vimeo/psalm/releases/tag/5.17.0)

[Compare
Source](https://github.com/vimeo/psalm/compare/5.16.0...5.17.0)

<!-- Release notes generated using configuration in .github/release.yml
at 5.x -->

#### What's Changed

##### Features

- Implement by-ref closure use analysis by
[@&#8203;danog](https://github.com/danog) in
[https://github.com/vimeo/psalm/pull/10419](https://github.com/vimeo/psalm/pull/10419)

##### Fixes

- Update MongoDB stubs for 1.17 by
[@&#8203;alcaeus](https://github.com/alcaeus) in
[https://github.com/vimeo/psalm/pull/10402](https://github.com/vimeo/psalm/pull/10402)
- Fix backtick analysis by [@&#8203;danog](https://github.com/danog)
in
[https://github.com/vimeo/psalm/pull/10409](https://github.com/vimeo/psalm/pull/10409)
- Declare we do not support document highlighting by
[@&#8203;tm1000](https://github.com/tm1000) in
[https://github.com/vimeo/psalm/pull/10408](https://github.com/vimeo/psalm/pull/10408)
- update define types to be correct by
[@&#8203;kkmuffme](https://github.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/10423](https://github.com/vimeo/psalm/pull/10423)
- Fix return type of DOMXPath::query by
[@&#8203;nielsdos](https://github.com/nielsdos) in
[https://github.com/vimeo/psalm/pull/10443](https://github.com/vimeo/psalm/pull/10443)
- Fix CLI -r error by [@&#8203;kkmuffme](https://github.com/kkmuffme)
in
[https://github.com/vimeo/psalm/pull/10442](https://github.com/vimeo/psalm/pull/10442)
- Use correct file path while adding unused suppressions for virtual
\__… by [@&#8203;danog](https://github.com/danog) in
[https://github.com/vimeo/psalm/pull/10434](https://github.com/vimeo/psalm/pull/10434)
- Restore support for null coalesce on match expressions by
[@&#8203;tscni](https://github.com/tscni) in
[https://github.com/vimeo/psalm/pull/10422](https://github.com/vimeo/psalm/pull/10422)
- Fix static magic method pureness not being inherited from traits by
[@&#8203;tscni](https://github.com/tscni) in
[https://github.com/vimeo/psalm/pull/10429](https://github.com/vimeo/psalm/pull/10429)
- Fix POSIX only detection of absolute paths by
[@&#8203;rarila](https://github.com/rarila) in
[https://github.com/vimeo/psalm/pull/10441](https://github.com/vimeo/psalm/pull/10441)
- Emit UnusedPsalmSuppress issues for suppressed issues already removed
by [@&#8203;danog](https://github.com/danog) in
[https://github.com/vimeo/psalm/pull/10431](https://github.com/vimeo/psalm/pull/10431)
- Use keyed arrays when assigning literal union keys & assertion fixes
by [@&#8203;danog](https://github.com/danog) in
[https://github.com/vimeo/psalm/pull/10439](https://github.com/vimeo/psalm/pull/10439)

##### Internal changes

- use branch name to randomize tests to ensure test dependencies will
error by [@&#8203;kkmuffme](https://github.com/kkmuffme) in
[https://github.com/vimeo/psalm/pull/10424](https://github.com/vimeo/psalm/pull/10424)

#### New Contributors

- [@&#8203;nielsdos](https://github.com/nielsdos) made their first
contribution in
[https://github.com/vimeo/psalm/pull/10443](https://github.com/vimeo/psalm/pull/10443)

**Full Changelog**:
vimeo/psalm@5.16.0...5.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-feature/php-sdk).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44MS4zIiwidXBkYXRlZEluVmVyIjoiMzcuODEuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Tom Carrio <tom@carrio.dev>
@kkmuffme kkmuffme deleted the use-pr-branch-name-for-randomization-of-tests branch December 5, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants