-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master
from 5.x
#10850
Draft
weirdan
wants to merge
49
commits into
vimeo:master
Choose a base branch
from
weirdan:update-master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Update master
from 5.x
#10850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for-array-access
Resolved problem: ``` Psalm\Tests\AssertAnnotationTest::testAssertsAllongCallStaticMethodWork Psalm\Exception\CodeException: LessSpecificReturnStatement The type 'string' is more general than the declared return type 'non-empty-string' for returnNonEmpty ```
`TClosure` does not implement it at this point. It's intentional, to maintain the separation between callables and closures that our code relies on.
…pertyNotSetInConstructor Fix vimeo#10786
Fixes all issues that emits a deprecation notice on PHP 8.4. See: - [RFC](https://wiki.php.net/rfc/deprecate-implicitly-nullable-types) - [PHP 8.4: Implicitly nullable parameter declarations deprecated](https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated)
…non-default PHP binary e.g. you run the tests with a php83 executable but your default php is PHP 7.4, it will suddenly change while running the tests leading to false positive errors
…an-called-from-php-version fix tests running with other than called PHP binary if called with a non-default PHP binary
…sts-config Explicitly set value in config to fix warning in tests
…-types-as-subtypes-of-callable
…urrent context Fix vimeo#10823 Fix vimeo#8509
…orted-in-callable
…rg-types-PHP81-83
…ch-for-single-param-too
…aram-name-mismatch
This prevents false positive for various types of issues inside empty, such as RedundantConditionGivenDocblockType and TypeDoesNotContainType.
…set-in-extended-constructor
…rs-not-reported
weirdan
added
the
release:internal
The PR will be included in 'Internal changes' section of the release notes
label
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
callable
__callStatic()
breaks asserts on 5.23 #10807__callStatic()
breaks asserts on 5.23 #10807TCallableInterface