Allow non-string keys #3221
Merged
Allow non-string keys #3221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muglug I would like to write a test, but I don't understand how they are organized. Can you recommend an existing file, or should I create a new one? |
greg0ire
force-pushed
the
lenient-array-change-key-case
branch
from
8223d30
to
333a51b
Compare
greg0ire
commented
Apr 24, 2020
| @@ -249,11 +249,12 @@ function uksort(array &$arr, callable $callback): bool | |||
| } | |||
|
|
|||
| /** | |||
| * @psalm-template K of array-key | |||
There was a problem hiding this comment.
🤔 maybe I should remove the of array-key part?
There was a problem hiding this comment.
You may do that, however it really shouldn't do any harm. After all, array keys could only be array-key. Come to think of it, it may even be useful to catch situations when Psalm wrongly infers key types, like here: https://psalm.dev/r/5c1dae6bd1
Answering my own question: https://github.com/vimeo/psalm/blob/master/tests/ArrayFunctionCallTest.php looks like a good candidate |
greg0ire
force-pushed
the
lenient-array-change-key-case
branch
from
333a51b
to
082c1fa
Compare
|
The same with a test, please review :) |
Although it would be stupid to provide an array with exclusively non-string keys, it's possible to have an array with a bit of both. See for instance https://github.com/doctrine/dbal/blob/155d028be084ef69110d09938c57c351a2126e5d/tests/Doctrine/Tests/DBAL/Functional/DataAccessTest.php#L263-L276
greg0ire
force-pushed
the
lenient-array-change-key-case
branch
from
082c1fa
to
8c1a183
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although it would be stupid to provide an array with exclusively
non-string keys, it's possible to have array with a bit of both.
See for instance
https://github.com/doctrine/dbal/blob/155d028be084ef69110d09938c57c351a2126e5d/tests/Doctrine/Tests/DBAL/Functional/DataAccessTest.php#L263-L276