-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use cache for declared function when available before falling back to stubs #8503
Merged
orklah
merged 1 commit into
vimeo:4.x
from
kkmuffme:fix-phpdoc-errors-reported-for-stubs-instead-of-files
Sep 22, 2022
Merged
use cache for declared function when available before falling back to stubs #8503
orklah
merged 1 commit into
vimeo:4.x
from
kkmuffme:fix-phpdoc-errors-reported-for-stubs-instead-of-files
Sep 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stubs fixes return type issues reported for the wrong file
Ready to be reviewed & merged :-) |
orklah
added
the
release:fix
The PR will be included in 'Fixes' section of the release notes
label
Sep 22, 2022
Thanks! |
Oh nice! I expected it to be a bit harder to fix than that. |
kkmuffme
deleted the
fix-phpdoc-errors-reported-for-stubs-instead-of-files
branch
September 23, 2022 11:13
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Dec 29, 2022
fixes return type issues of methods reported for the wrong file Fix vimeo#8457 See vimeo#8503 which fixed this issue for functions
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Dec 29, 2022
fixes return type issues of methods reported for the wrong file Fix vimeo#8457 See vimeo#8503 which fixed this issue for functions
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Dec 29, 2022
fixes return type issues of methods reported for the wrong file Fix vimeo#8457 See vimeo#8503 which fixed this issue for functions
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 15, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed) With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 15, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed) With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 16, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 16, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed) With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 16, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 16, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed) With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 16, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 16, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed) With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 16, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 16, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed) With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 18, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 18, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed) With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 18, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme
added a commit
to kkmuffme/psalm
that referenced
this pull request
Nov 18, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed) With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes return type issues reported for the wrong file
Fix #8457