Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfurl adaptive video file links #77

Merged
merged 7 commits into from
Feb 12, 2019
Merged

Conversation

juniorxsound
Copy link
Contributor

@juniorxsound juniorxsound commented Feb 7, 2019

What?

Tested against:

  • Unity 2018.2.18f1
  • Unity 2017.4.16f1

@juniorxsound juniorxsound self-assigned this Feb 7, 2019
@caseypugh caseypugh changed the title Add adaptive link unfurling to get the adaptive manifest files Unfurl adaptive video file links Feb 8, 2019
Assets/Vimeo/Scripts/Player/VimeoPlayer.cs Outdated Show resolved Hide resolved
Assets/Vimeo/Scripts/Player/VimeoPlayer.cs Show resolved Hide resolved
Assets/Vimeo/Scripts/TestConfigSample.cs Outdated Show resolved Hide resolved
Assets/Tests/Play/VimeoPlayerPlayTest.cs Outdated Show resolved Hide resolved
@caseypugh
Copy link
Contributor

Tested in 2017.1 all the tests pass except for:

GetAdaptiveVideoFileURL_Returns_Dash_By_Default 
GetAdaptiveVideoFileURL_Defaults_To_Hls_For_Files_Response

Do you get that?

@juniorxsound
Copy link
Contributor Author

Seems to be working for me, tested against 2017.1.5f1

tests

@juniorxsound juniorxsound merged commit acd5011 into master Feb 12, 2019
@juniorxsound juniorxsound deleted the adaptive-unfurl-patch branch February 12, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants