Use CSI for key events #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially some unicode chars where used for the arrow keys, but switching from ASCII to Extended ASCII introduced a visual bug for login and other programs reading an input line.
Dealing with unicode as bytes is error prone. This PR replace the unicode chars for arrow keys with their classic CSI equivalent. Userspace programs need to be updated because getting the char sequence for an arrow key require 3 calls to
console::get_charinstead of one, but this solution is more portable. It also mean the we will be able to be more interactive in serial mode.https://en.wikipedia.org/wiki/ANSI_escape_code