Use exit code to set status var #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinc
changed the title
|
Some tests with Calling the console to print an empty string with the serial driver consistently fix them, but calling the serial driver directly doesn't work. |
|
With this last commit we go back to the usual |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should a program exit or return with a
isize,usize,ExitCode,Result<(), usize>, orResult<(), ExitCode>. A few options were tried in this PR to end up on the latter, but we may simplify it again as it was before toExitCode.At least now we can get the code with
print $?in the shell, and the userspace binaries no longer need to return anything by default instead of0.