Improve app UX and simplify interface #17
Conversation
|
Thanks 🙂 |
The arrow is pretty nice but there was a bug where it doesn't keep the correct position on resize (also wasn't updating correctly in dark mode for some reason)? Could spend time fixing it but I personally think it looks really clean and more like a native app without it. Being able to move the window has been a really useful feature, since it's nice to drag it out of the way if it's overlaying important content 👍 |
| @@ -96,7 +101,7 @@ app.on("ready", () => { | |||
|
|
|||
| const menu = new Menu(); | |||
|
|
|||
| globalShortcut.register("CommandOrControl+Shift+g", () => { | |||
| globalShortcut.register("CommandOrControl+Alt+g", () => { | |||
There was a problem hiding this comment.
I would be cautious about making this change, as it isn't backwards-compatible and people may already be accustomed to the current shortcut. Additionally, I believe the new one is already used by Google Drive.
There was a problem hiding this comment.
The original shortcut is honestly easier to press on both Win and Mac (for my hand anyway)
| @@ -1,4 +1,5 @@ | |||
| require("update-electron-app")(); | |||
| const electronReload = require("electron-reload"); | |||
| @@ -18,6 +19,10 @@ const image = nativeImage.createFromPath( | |||
| path.join(__dirname, `images/newiconTemplate.png`) | |||
| ); | |||
|
|
|||
| require("electron-reload")(__dirname, { | |||
| electron: path.join(__dirname, "node_modules", ".bin", "electron"), | |||
There was a problem hiding this comment.
Is this compatible with electron-forge make?
edit: Isn't this a development tool - why's it in the PR
Great work with this @vincelwt - I've added some fixes in my build that you are welcome to implement. Happy to keep contributing to the project if you'd like some help 😃
Demo.mp4