Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove skeptic #84

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Nov 14, 2024

It is unmaintained and fails to build tests.

Same as vincent-herlemont/native_db#286.

@vincent-herlemont
Copy link
Owner

@lu-zero Thank you for your PR!

An issue has been opened for this (#76). It is important that the code in the Readme can continue to be tested by the CI. Therefore, in the same PR for removal, it is necessary to find a way to replace it.

In the case of vincent-herlemont/native_db#286 it is not the same thing because #[doc = include_str!("../../README.md")] was already done which allowed testing the code in the Readme.

README.md Outdated Show resolved Hide resolved
It is unmaintained and fails to build tests.

Same as vincent-herlemont/native_db#286.
@vincent-herlemont vincent-herlemont merged commit 36e1706 into vincent-herlemont:main Nov 14, 2024
5 checks passed
@vincent-herlemont vincent-herlemont linked an issue Nov 14, 2024 that may be closed by this pull request
@vincent-herlemont
Copy link
Owner

🎉 This PR is included in version 0.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lu-zero lu-zero deleted the drop-skeptic branch November 14, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The code in the readme is no longer tested
2 participants