Add Single step invite and process partner process capability (rubyfo…

…rgood#4075)

* Add new column use_single_step_invite_and_approve_partner_process

* Allow editing (enabling and disabling) of one step invite and approval process in organization page

* Add invite and approve capability

* Update migration to have not null constraint

* Rename action to invite_and_approve

* Remove extraneous add to schema.rb

* Remove extraneous ui helper; reuse invite button helper

* Rename field to one_step_invite_and_approve

* Readd mistakenly removed null false

* Add systems spec for one step partner invite

* Change button color to yellow to match invite button

* Correct lint errors

* Fix system spec

* More accurate spec message

* Use correct route in specs

app/controllers/organizations_controller.rb

@@ -97,7 +97,8 @@ def organization_params
       :repackage_essentials, :distribute_monthly,
       :ndbn_member_id, :enable_child_based_requests,
       :enable_individual_requests, :enable_quantity_based_requests,
-      :ytd_on_distribution_printout, partner_form_fields: []
+      :ytd_on_distribution_printout, :one_step_partner_invite,
+      partner_form_fields: []
     )
   end
 

app/controllers/partners_controller.rb

@@ -49,6 +49,28 @@ def approve_application
     end
   end
 
+  def invite_and_approve
+    # Invite the partner
+    partner = current_organization.partners.find(params[:id])
+
+    partner_invite_service = PartnerInviteService.new(partner: partner, force: true)
+    partner_invite_service.call
+
+    # If no errors inviting, then approve the partner
+    if partner_invite_service.errors.none?
+      partner_approval_service = PartnerApprovalService.new(partner: partner)
+      partner_approval_service.call
+
+      if partner_approval_service.errors.none?
+        redirect_to partners_path, notice: "Partner invited and approved!"
+      else
+        redirect_to partners_path, error: "Failed to approve partner because: #{partner_approval_service.errors.full_messages}"
+      end
+    else
+      redirect_to partners_path, notice: "Failed to invite #{partner.name}! #{partner_invite_service.errors.full_messages}"
+    end
+  end
+
   def show
     @partner = current_organization.partners.find(params[:id])
     @impact_metrics = @partner.impact_metrics unless @partner.uninvited?

app/models/organization.rb

@@ -2,33 +2,34 @@
 #
 # Table name: organizations
 #
-#  id                             :integer          not null, primary key
-#  city                           :string
-#  deadline_day                   :integer
-#  default_storage_location       :integer
-#  distribute_monthly             :boolean          default(FALSE), not null
-#  email                          :string
-#  enable_child_based_requests    :boolean          default(TRUE), not null
-#  enable_individual_requests     :boolean          default(TRUE), not null
-#  enable_quantity_based_requests :boolean          default(TRUE), not null
-#  intake_location                :integer
-#  invitation_text                :text
-#  latitude                       :float
-#  longitude                      :float
-#  name                           :string
-#  partner_form_fields            :text             default([]), is an Array
-#  reminder_day                   :integer
-#  repackage_essentials           :boolean          default(FALSE), not null
-#  short_name                     :string
-#  state                          :string
-#  street                         :string
-#  url                            :string
-#  ytd_on_distribution_printout   :boolean          default(TRUE), not null
-#  zipcode                        :string
-#  created_at                     :datetime         not null
-#  updated_at                     :datetime         not null
-#  account_request_id             :integer
-#  ndbn_member_id                 :bigint
+#  id                                                 :integer          not null, primary key
+#  city                                               :string
+#  deadline_day                                       :integer
+#  default_storage_location                           :integer
+#  distribute_monthly                                 :boolean          default(FALSE), not null
+#  email                                              :string
+#  enable_child_based_requests                        :boolean          default(TRUE), not null
+#  enable_individual_requests                         :boolean          default(TRUE), not null
+#  enable_quantity_based_requests                     :boolean          default(TRUE), not null
+#  intake_location                                    :integer
+#  invitation_text                                    :text
+#  latitude                                           :float
+#  longitude                                          :float
+#  name                                               :string
+#  partner_form_fields                                :text             default([]), is an Array
+#  reminder_day                                       :integer
+#  repackage_essentials                               :boolean          default(FALSE), not null
+#  short_name                                         :string
+#  state                                              :string
+#  street                                             :string
+#  url                                                :string
+#  one_step_partner_invite                            :boolean          default(FALSE), not null
+#  ytd_on_distribution_printout                       :boolean          default(TRUE), not null
+#  zipcode                                            :string
+#  created_at                                         :datetime         not null
+#  updated_at                                         :datetime         not null
+#  account_request_id                                 :integer
+#  ndbn_member_id                                     :bigint
 #
 
 class Organization < ApplicationRecord

app/views/organizations/_details.html.erb

@@ -152,6 +152,12 @@
                   <%= humanize_boolean(@organization.ytd_on_distribution_printout) %>
                 </p>
               </div>
+              <div class="mb-4">
+                <h3 class='font-bold'>Use One step Partner invite and approve process?</h3>
+                <p>
+                  <%= humanize_boolean(@organization.one_step_partner_invite) %>
+                </p>
+              </div>
               <% if @organization.logo.attached? %>
                     <div class="mb-4">
                     <h3 class='font-bold'>Logo</h3>

app/views/organizations/edit.html.erb

@@ -85,6 +85,7 @@
                 <%= f.input :enable_individual_requests, label: 'Enable partners to make requests for individuals?', as: :radio_buttons, collection: [[true, 'Yes'], [false, 'No']], label_method: :second, value_method: :first %>
                 <%= f.input :enable_quantity_based_requests, label: 'Enable partners to make quantity-based requests?', as: :radio_buttons, collection: [[true, 'Yes'], [false, 'No']], label_method: :second, value_method: :first %>
                 <%= f.input :ytd_on_distribution_printout, label: 'Show Year-to-date values on distribution printout?', as: :radio_buttons, collection: [[true, 'Yes'], [false, 'No']], label_method: :second, value_method: :first %>
+                <%= f.input :one_step_partner_invite, label: 'Use One Step Invite and Approve partner process?', as: :radio_buttons, collection: [[true, 'Yes'], [false, 'No']], label_method: :second, value_method: :first %>
 
                 <% default_email_text_hint = "You can use the variables <code>%{partner_name}</code>, <code>%{delivery_method}</code>, <code>%{distribution_date}</code>, and <code>%{comment}</code> to include the partner's name, delivery method, distribution date, and comments sent in the request." %>
                 <%= f.input :default_email_text, label: "Distribution Email Content", hint: default_email_text_hint.html_safe do %>

app/views/partners/_partner_row.html.erb

@@ -1,4 +1,6 @@
 <% status = partner_row.status %>
+<% can_one_step_invite_and_approve = partner_row.organization.one_step_partner_invite %>
+
 <tr>
   <td class='text-blue-500'><%= link_to partner_row.name, partner_path(partner_row) %></td>
   <td><%= link_to partner_row.email, "mailto:#{partner_row.email}" %></td>
@@ -25,7 +27,12 @@
   <td>
     <% case status %>
     <% when "uninvited" %>
-      <%= invite_button_to(invite_partner_path(partner_row), confirm: "Send an invitation to #{partner_row.name} to begin using the partner application?") %>
+      <% if can_one_step_invite_and_approve %>
+        <% button_options = { icon: "envelope", type: "warning", text: "Invite and Approve", size: "xs", confirm: "One step invite and approve #{partner_row.name} to begin using the partner application?" } %>
+        <%= invite_button_to(invite_and_approve_partner_path(partner_row), button_options) %>
+      <% else %>
+        <%= invite_button_to(invite_partner_path(partner_row), confirm: "Send an invitation to #{partner_row.name} to begin using the partner application?") %>
+      <% end %>
     <% when "invited" %>
       <%= view_button_to partner_path(partner_row) + "#partner-information", { text: "Review Application", icon: "check", type: "warning" } %>
       <%= invite_button_to(invite_partner_path(partner_row), confirm: "Re-send an invitation to #{partner_row.name}?", text: 'Re-send Invite') %>

config/routes.rb

@@ -177,6 +177,7 @@ def set_up_flipper
         patch :profile
         get :approve_application
         post :invite
+        post :invite_and_approve
         post :invite_partner_user
         post :recertify_partner
         put :deactivate

db/migrate/20240131202431_add_one_step_partner_invite_to_organization.rb

@@ -0,0 +1,6 @@
+class AddOneStepPartnerInviteToOrganization < ActiveRecord::Migration[7.0]
+  def change
+    add_column :organizations, :one_step_partner_invite, :boolean, null: false
+    change_column_default :organizations, :one_step_partner_invite, false
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2023_12_29_200106) do
+ActiveRecord::Schema[7.0].define(version: 2024_01_31_202431) do
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
 
@@ -478,6 +478,7 @@
     t.boolean "enable_individual_requests", default: true, null: false
     t.boolean "enable_quantity_based_requests", default: true, null: false
     t.boolean "ytd_on_distribution_printout", default: true, null: false
+    t.boolean "one_step_partner_invite", default: false, null: false
     t.index ["latitude", "longitude"], name: "index_organizations_on_latitude_and_longitude"
     t.index ["short_name"], name: "index_organizations_on_short_name"
   end

spec/factories/organizations.rb

@@ -2,33 +2,34 @@
 #
 # Table name: organizations
 #
-#  id                             :integer          not null, primary key
-#  city                           :string
-#  deadline_day                   :integer
-#  default_storage_location       :integer
-#  distribute_monthly             :boolean          default(FALSE), not null
-#  email                          :string
-#  enable_child_based_requests    :boolean          default(TRUE), not null
-#  enable_individual_requests     :boolean          default(TRUE), not null
-#  enable_quantity_based_requests :boolean          default(TRUE), not null
-#  intake_location                :integer
-#  invitation_text                :text
-#  latitude                       :float
-#  longitude                      :float
-#  name                           :string
-#  partner_form_fields            :text             default([]), is an Array
-#  reminder_day                   :integer
-#  repackage_essentials           :boolean          default(FALSE), not null
-#  short_name                     :string
-#  state                          :string
-#  street                         :string
-#  url                            :string
-#  ytd_on_distribution_printout   :boolean          default(TRUE), not null
-#  zipcode                        :string
-#  created_at                     :datetime         not null
-#  updated_at                     :datetime         not null
-#  account_request_id             :integer
-#  ndbn_member_id                 :bigint
+#  id                                                 :integer          not null, primary key
+#  city                                               :string
+#  deadline_day                                       :integer
+#  default_storage_location                           :integer
+#  distribute_monthly                                 :boolean          default(FALSE), not null
+#  email                                              :string
+#  enable_child_based_requests                        :boolean          default(TRUE), not null
+#  enable_individual_requests                         :boolean          default(TRUE), not null
+#  enable_quantity_based_requests                     :boolean          default(TRUE), not null
+#  intake_location                                    :integer
+#  invitation_text                                    :text
+#  latitude                                           :float
+#  longitude                                          :float
+#  name                                               :string
+#  partner_form_fields                                :text             default([]), is an Array
+#  reminder_day                                       :integer
+#  repackage_essentials                               :boolean          default(FALSE), not null
+#  short_name                                         :string
+#  state                                              :string
+#  street                                             :string
+#  url                                                :string
+#  one_step_partner_invite                            :boolean          default(FALSE), not null
+#  ytd_on_distribution_printout                       :boolean          default(TRUE), not null
+#  zipcode                                            :string
+#  created_at                                         :datetime         not null
+#  updated_at                                         :datetime         not null
+#  account_request_id                                 :integer
+#  ndbn_member_id                                     :bigint
 #
 
 FactoryBot.define do

spec/models/event_spec.rb

@@ -1,3 +1,18 @@
+# == Schema Information
+#
+# Table name: events
+#
+#  id              :bigint           not null, primary key
+#  data            :jsonb
+#  event_time      :datetime         not null
+#  eventable_type  :string
+#  type            :string           not null
+#  created_at      :datetime         not null
+#  updated_at      :datetime         not null
+#  eventable_id    :bigint
+#  organization_id :bigint
+#  user_id         :bigint
+#
 RSpec.describe Event, type: :model do
   let(:organization) { FactoryBot.create(:organization) }
   describe "#most_recent_snapshot" do

spec/models/organization_spec.rb

@@ -2,33 +2,34 @@
 #
 # Table name: organizations
 #
-#  id                             :integer          not null, primary key
-#  city                           :string
-#  deadline_day                   :integer
-#  default_storage_location       :integer
-#  distribute_monthly             :boolean          default(FALSE), not null
-#  email                          :string
-#  enable_child_based_requests    :boolean          default(TRUE), not null
-#  enable_individual_requests     :boolean          default(TRUE), not null
-#  enable_quantity_based_requests :boolean          default(TRUE), not null
-#  intake_location                :integer
-#  invitation_text                :text
-#  latitude                       :float
-#  longitude                      :float
-#  name                           :string
-#  partner_form_fields            :text             default([]), is an Array
-#  reminder_day                   :integer
-#  repackage_essentials           :boolean          default(FALSE), not null
-#  short_name                     :string
-#  state                          :string
-#  street                         :string
-#  url                            :string
-#  ytd_on_distribution_printout   :boolean          default(TRUE), not null
-#  zipcode                        :string
-#  created_at                     :datetime         not null
-#  updated_at                     :datetime         not null
-#  account_request_id             :integer
-#  ndbn_member_id                 :bigint
+#  id                                                 :integer          not null, primary key
+#  city                                               :string
+#  deadline_day                                       :integer
+#  default_storage_location                           :integer
+#  distribute_monthly                                 :boolean          default(FALSE), not null
+#  email                                              :string
+#  enable_child_based_requests                        :boolean          default(TRUE), not null
+#  enable_individual_requests                         :boolean          default(TRUE), not null
+#  enable_quantity_based_requests                     :boolean          default(TRUE), not null
+#  intake_location                                    :integer
+#  invitation_text                                    :text
+#  latitude                                           :float
+#  longitude                                          :float
+#  name                                               :string
+#  partner_form_fields                                :text             default([]), is an Array
+#  reminder_day                                       :integer
+#  repackage_essentials                               :boolean          default(FALSE), not null
+#  short_name                                         :string
+#  state                                              :string
+#  street                                             :string
+#  url                                                :string
+#  one_step_partner_invite                            :boolean          default(FALSE), not null
+#  ytd_on_distribution_printout                       :boolean          default(TRUE), not null
+#  zipcode                                            :string
+#  created_at                                         :datetime         not null
+#  updated_at                                         :datetime         not null
+#  account_request_id                                 :integer
+#  ndbn_member_id                                     :bigint
 #
 
 RSpec.describe Organization, type: :model do