-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 8/pass ci polars skip #11
Merged
vincentarelbundock
merged 17 commits into
vincentarelbundock:main
from
frank113:issue_8/pass_ci_polars_skip
Nov 2, 2023
Merged
Issue 8/pass ci polars skip #11
vincentarelbundock
merged 17 commits into
vincentarelbundock:main
from
frank113:issue_8/pass_ci_polars_skip
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #8 to ensure that the CI checks pass. This PR is a stop-gap solution to clean up the CI checks so that future failures can be caught expeditiously. Some of the
polars
functionality blurs the line mentioned in the a comment in the parent issue. For a future PR it is my belief thepolars
tests should be re-worked. This PR keeps thepolars
functionality to ensure that scenarios are tested even if in a non-optimal way.Changes Made
countrycode
to ensure that the linting CI check passes.polars
and run tests denoted as*_polars
custom_strategies
to reflect the dictionary representation ofcodelist
empty_string_to_null
helper function to account for the dictionary representation ofcodelist
coercing empty string values (previously seen asNone
natively) toNone
custom_strategies
tocustom_strategies_polars
. Based on comments on the issue thread itself I would like to sunset these as soon as possible but am leaving them in for this PR until we have conversion unit tests for the dictionary representation ofcodelist
test_numeric
totest_conversion_polars
. When using the dictionary representation ofcodelist
theiso3n
column was the string representation of a number rather than a number. We can solidify this behavior when porting the tests to not usepolars
polars
ifpolars
is not installed. The skips occur at the module and file levels.Considerations
polars
functionality in later PRs.