-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingest different df types + tests #134
ingest different df types + tests #134
Conversation
ca086b6
to
a7a60cd
Compare
a7a60cd
to
cb4d158
Compare
@vincentarelbundock This one should do the trick for issue #108
|
|
if isinstance(obj, pd.DataFrame): | ||
obj = pl.DataFrame(obj) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like obj
is of type model
and it shouldn't ever be of type dataframe
. It was introduced here #94 but not sure why. I also checked in R and obj
is not a dataframe
in R either.
If it were to be a dataframe all the following operations would fail so I think we can remove it. @vincentarelbundock do you agree?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems right but I won't have time to dig deep, so I'll trust you here.
@vincentarelbundock please review and don't hesitate to share your comments. |
No description provided.