-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
rusage can be used for more stats later.
Do not diff rss, it is always used as max
maxrss is not very useful in a microbenchmark
Also, print them in the same order as specified in measureAccessors_
f781326
to
b68cfc2
Compare
143b31d
to
23e2a6a
Compare
The new stats include maxrss stat and it showed what the problem is with #2. The rss keeps on increasing as the benchmarks proceed which indicates memory being held up. It could be because the data structures are being shared by multiple benchmarks in the same suite, therefore are not released even after the test is done.
Also the GC stats/methodology seem to be screwed up, as they are showing negative numbers:
|
@vincenthz I am done with this, you can review this first and merge and then I will resolve #8 as these two conflict. I have more changes regarding quick-mode and layering the statistical analysis part above measurement so that they are cleanly separated, if you can get this one out of the way quickly then that will be easier. Thought for later, the statistical analysis and presentation kind of part can even live in a separate package say, |
apart from the small niggles, I think it all look good and useful. thanks ! |
@vincenthz thanks. I know there are niggles, just record it somewhere if it is worth it or you can fix them as and when you go over those parts. At this point let's focus on getting the major changes done and in the due course we can polish it better. The FFI stuff will have to be changed to be in line with your change. |
@harendra-kumar absolutely, I'ld rather iterate quickly to get to our goals than be stuck in small details that are all-in-all not that important. adding getrusage is definitely an improvement that supersedes niggles. |
There are some important insights that can be gained from stats obtained via getrusage e.g.:
I have added these stats and enabled printing of these in verbose mode as of now.
Note: The printing of stats in general can later be implemented using a stat specific show function in
measureAccessors_
.