Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert set to sealed interface. #80

Merged
merged 6 commits into from
Jan 2, 2025
Merged

Convert set to sealed interface. #80

merged 6 commits into from
Jan 2, 2025

Conversation

vincentk
Copy link
Owner

@vincentk vincentk commented Jan 2, 2025

Convert set to sealed interface permitting non-empty and empty subtypes only.

@vincentk vincentk changed the title Convert set to sealed interface permitting empty and non-empty sets o… Convert set to sealed interface. Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Overall Project 65.47% -2.11% 🍏
Files changed 41.94%

File Coverage
PoSet.java 100% 🍏
EmptySet.java 100% 🍏
Set.java 83.33% 🍏
NonEmptySet.java 67.86% -32.14% 🍏
Magma.java 50% 🍏
Union.java 0% -75%

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 60.13%. Comparing base (e950f1a) to head (865fbe0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../java/com/github/vincentk/dedekind/sets/Union.java 33.33% 2 Missing and 2 partials ⚠️
...com/github/vincentk/dedekind/sets/NonEmptySet.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #80      +/-   ##
============================================
+ Coverage     59.64%   60.13%   +0.49%     
- Complexity       54       59       +5     
============================================
  Files            40       40              
  Lines           280      286       +6     
  Branches         40       42       +2     
============================================
+ Hits            167      172       +5     
+ Misses           93       92       -1     
- Partials         20       22       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 2, 2025

Overall Project 66.63% -1.74% 🍏
Files changed 63.41% 🍏

File Coverage
PoSet.java 100% 🍏
EmptySet.java 100% 🍏
SingletonSet.java 95.83% 🍏
NonEmptySet.java 93.1% -6.9% 🍏
Set.java 79.63% 🍏
Magma.java 50% 🍏
Union.java 44% -56%

Copy link

github-actions bot commented Jan 2, 2025

Overall Project 66.63% -1.74% 🍏
Files changed 63.41% 🍏

File Coverage
PoSet.java 100% 🍏
EmptySet.java 100% 🍏
SingletonSet.java 95.83% 🍏
NonEmptySet.java 93.1% -6.9% 🍏
Set.java 79.63% 🍏
Magma.java 50% 🍏
Union.java 44% -56%

Copy link

github-actions bot commented Jan 2, 2025

Overall Project 67.5% -0.87% 🍏
Files changed 81.71% 🍏

File Coverage
PoSet.java 100% 🍏
EmptySet.java 100% 🍏
SingletonSet.java 95.83% 🍏
NonEmptySet.java 93.1% -6.9% 🍏
Set.java 79.63% 🍏
Union.java 74% -26% 🍏
Magma.java 50% 🍏

Copy link

github-actions bot commented Jan 2, 2025

Overall Project 67.5% -0.87% 🍏
Files changed 81.71% 🍏

File Coverage
PoSet.java 100% 🍏
EmptySet.java 100% 🍏
SingletonSet.java 95.83% 🍏
NonEmptySet.java 93.1% -6.9% 🍏
Set.java 79.63% 🍏
Union.java 74% -26% 🍏
Magma.java 50% 🍏
DirectedSet.java 0% 🍏
SemiLattice.java 0% 🍏

@vincentk vincentk marked this pull request as ready for review January 2, 2025 16:50
@vincentk vincentk merged commit f8f1427 into main Jan 2, 2025
1 check passed
@vincentk vincentk deleted the relations-on-sets branch January 2, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant