CMake: Fix Python3 and Doxygen invocations.

[tamaskenez]

No description provided.

[codecov]

Codecov Report

Merging #49 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #49      +/-   ##
=======================================
+ Coverage   96.99%   97%   +<.01%     
=======================================
  Files          13    13              
  Lines         766   768       +2     
=======================================
+ Hits          743   745       +2     
  Misses         23    23

Impacted Files	Coverage Δ
include/internal/csv_row.cpp	100% <ø> (ø)	⬆️
include/internal/row_buffer.hpp	100% <ø> (ø)	⬆️
include/internal/csv_reader.cpp	99.6% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c7830f...fdeb7aa. Read the comment docs.

[vincentlaucsb]

Hi @tamaskenez, thanks for submitting a PR. I like a lot of the changes I see here. I'm just wondering if it's not necessary to specify the optimization flags for g++. I'm not the biggest CMake expert.

[tamaskenez]

There are a few things I need to say:

• Sorry about the many changes, I did not want to include all of these changes in to the 2 PRs. I just pushed new commits to my master and forgot that they will show up in the PR. So let's put this on hold, tomorrow I'll remove the unwanted changes and you can review again.
• In CMake the general rule is to not check CMAKE_BUILD_TYPE ever, because it's meaningless with IDE-generators (like MSVC, Xcode).
• You can still set config dependent flags with CMAKE_CXX_FLAGS_DEBUG, etc... but CMake already adds all the necessary -O flags to DEBUG and non-DEBUG builds.
• I probably made one error here: I removed -pthread but the parser does need pthread with gcc, right? Even if it does, there's a better way to add it, I'll do it tomorrow.

[vincentlaucsb]

Yes the CSV parser uses threads and won't compile without -pthread

[tamaskenez]

I removed the unnecessary changes from my master, so this is only 1 file, please review.

[vincentlaucsb]

Do you think it's possible to incorporate the suggestions from #6?

[tamaskenez]

Do you think it's possible to incorporate the suggestions from #6?

Yes, I can do it. I mean, I suggest not to extend to scope of this PR. I'll do it in a separate CL.

[vincentlaucsb]

Yes you're right. Thanks again for your help!