Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roblozx 2024 vingar fix #418

Closed
wants to merge 1 commit into from
Closed

Conversation

ios7jbpro
Copy link

this works!!!!!!!! i tested

@apprehensions
Copy link
Member

Please fix the CI.

@Atemo-C
Copy link

Atemo-C commented May 30, 2024

If one shall troll, at least one shall do it somewhat properly.

vinegar_installer.sh:

#!/usr/bin/env sh

curl "https://software.download.prss.microsoft.com/dbazure/Win11_23H2_English_x64v2.iso\?t\=a9233366-dec0-4aa1-b776-c240e83a7fe5\&P1\=1717103502\&P2\=601\&P3\=2\&P4\=q3%2fsICPFsEA7xTYqtAv%2b8yv2b%2bL1DdQd4POc3cccG5%2f0KWGNl%2b6N%2fAM0B8raZbrui1%2fxyq0Y%2fde546sE8i8uNBGp9StRkFaUg4HI4lK1IcMND0ybgiEbdoM6RmBMNgJxhUFPk8dKEXNi1CHD6Q4jtoJYLSMpjaoF8jUIiZFFjGdiMLBhbQEeSs30OZ1pMq7f2JxvOxMo9fhlZtwYD%2fc4FyFsZCb7tkJfBZ7OLmJrEIc3taR6MYelL6gRONbV147Uq8OGUMApnW9jNCF%2bYLRLdlSbNgoTjWcjKEdh0EkEbxoP3Ol0%2bimW5K9qIAG%2fGhkBnx6ftjFZ2oZYU6l1sQ8%2ftA%3d%3d" \
	--output Windows_11.iso || \
	echo "An error occured whilst downloading the Windows 11 ISO image."

Explanations

Shebang

No shebang was provided in the original file.
#!/usr/bin/env sh is a distribution-agnostic shell shebang that is guaranteed to use the default system shell for running this simple script. Be it bash, fish, ZSH, it matters not, for all of them will run this set of commands the same way by default. If one wants to specify a shell like bash, however, simply replace sh by it.

Curl download

Putting the link of the download between "..." is generally recommended to avoid unexpected issues, such as a command understanding part of the URL as an argument, or something else unexpected happening.

Spacing

\ is useful to separate different commands to make the script more readable and easier to edit.

Error output

A very rudimentary echo if any error occurs. Bare-bones and not very useful, but better than nothing at all.

Other troll improvements

Flashing tool

Downloading a tool like Balena Etcher to easily create a bootable Windows 11 medium from the downloaded ISO image would help the user as well.

Documentation changes

Documentation should be updated to include a step-by-step guide to create a bootable Windows 11 medium, install it on compatible hardware, configure it properly, then installing Roblox on it, be it via the official website or via the Microsoft Store.


But why?

Please, just no. I smiled, though. :)

@PetrifiedOak
Copy link

If one shall troll, at least one shall do it somewhat properly.

vinegar_installer.sh:

#!/usr/bin/env sh

curl "https://software.download.prss.microsoft.com/dbazure/Win11_23H2_English_x64v2.iso\?t\=a9233366-dec0-4aa1-b776-c240e83a7fe5\&P1\=1717103502\&P2\=601\&P3\=2\&P4\=q3%2fsICPFsEA7xTYqtAv%2b8yv2b%2bL1DdQd4POc3cccG5%2f0KWGNl%2b6N%2fAM0B8raZbrui1%2fxyq0Y%2fde546sE8i8uNBGp9StRkFaUg4HI4lK1IcMND0ybgiEbdoM6RmBMNgJxhUFPk8dKEXNi1CHD6Q4jtoJYLSMpjaoF8jUIiZFFjGdiMLBhbQEeSs30OZ1pMq7f2JxvOxMo9fhlZtwYD%2fc4FyFsZCb7tkJfBZ7OLmJrEIc3taR6MYelL6gRONbV147Uq8OGUMApnW9jNCF%2bYLRLdlSbNgoTjWcjKEdh0EkEbxoP3Ol0%2bimW5K9qIAG%2fGhkBnx6ftjFZ2oZYU6l1sQ8%2ftA%3d%3d" \
	--output Windows_11.iso || \
	echo "An error occured whilst downloading the Windows 11 ISO image."

Explanations

Shebang

No shebang was provided in the original file. #!/usr/bin/env sh is a distribution-agnostic shell shebang that is guaranteed to use the default system shell for running this simple script. Be it bash, fish, ZSH, it matters not, for all of them will run this set of commands the same way by default. If one wants to specify a shell like bash, however, simply replace sh by it.

Curl download

Putting the link of the download between "..." is generally recommended to avoid unexpected issues, such as a command understanding part of the URL as an argument, or something else unexpected happening.

Spacing

\ is useful to separate different commands to make the script more readable and easier to edit.

Error output

A very rudimentary echo if any error occurs. Bare-bones and not very useful, but better than nothing at all.

Other troll improvements

Flashing tool

Downloading a tool like Balena Etcher to easily create a bootable Windows 11 medium from the downloaded ISO image would help the user as well.

Documentation changes

Documentation should be updated to include a step-by-step guide to create a bootable Windows 11 medium, install it on compatible hardware, configure it properly, then installing Roblox on it, be it via the official website or via the Microsoft Store.

But why?

Please, just no. I smiled, though. :)

Youre wrong too, #!/usr/bin/env sh is never used, env is only used for bash, sh is ALWAYS located at /bin/sh

@apprehensions
Copy link
Member

Don't ruin the Fun 👐

this works!!!!!!!! i tested
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants