Skip to content

Commit

Permalink
[optimizer] improvement: ignoring more unneeded Wine child processes
Browse files Browse the repository at this point in the history
  • Loading branch information
vinifmor committed Aug 12, 2023
1 parent ed41c0a commit 818601c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
## [1.3.3] 2023-08-12

### Improvements
- optimizer: ignoring more unneeded EA launcher child processes
- optimizer: ignoring more unneeded EA launcher and Wine child processes

### Fixes
- watcher/optimizer: not able to map processes alive with `ps` command version >= 4.0.X
Expand Down
2 changes: 1 addition & 1 deletion guapow/service/optimizer/launcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ def to_ignore(self) -> Set[str]:
"UplayService.ex", "UplayWebCore.ex", "CrRendererMain", "regsvr32", "CrGpuMain",
"CrUtilityMain", "whql:off", "PnkBstrA.exe", "EABackgroundSer", "EADesktop.exe",
"EALocalHostSvc.", "EADestager.exe", "EALaunchHelper", "Link2EA.exe",
"ThreadPoolSingl ", "CrBrowserMain"}
"ThreadPoolSingl ", "CrBrowserMain", "rundll32.exe", "iexplore.exe", "UnityCrashHandl"}

return self._to_ignore

Expand Down
3 changes: 2 additions & 1 deletion tests/service/optimizer/test_launcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,8 @@ def test_to_ignore__must_contain_ea_origin_processes(self):
def test_to_ignore__must_contain_wine_processes(self):
expected_processes = {"wineserver", "services.exe", "winedevice.exe", "plugplay.exe", "svchost.exe",
"explorer.exe", "rpcss.exe", "tabtip.exe", "wine", "wine64", "wineboot.exe",
"cmd.exe", "conhost.exe", "start.exe"}
"cmd.exe", "conhost.exe", "start.exe", "winemenubuilder", "rundll32.exe", "iexplore.exe",
"UnityCrashHandl"}

self.assertTrue(expected_processes.issubset(self.mapper.to_ignore))

Expand Down

0 comments on commit 818601c

Please sign in to comment.