fixing reallocs again

vinissou · Oct 5, 2024 · 1e0bce9 · 1e0bce9
1 parent 77c764e
commit 1e0bce9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/modules/output.c b/src/modules/output.c
@@ -32,26 +32,29 @@ short int  OUTPUT_STDOUT = 0;
 short int  OUTPUT_RETURN = 0; //implement return option
 
 //TODO VVV does it need to be static???
-static char *output_buffer = NULL;
+//static char *output_buffer = NULL;
 
 
 
 
 /* Make this work with buffered chunks*/
 //TODO this is used in copy.h, FIX THIS >>> copy it there
-char *ReturnOutput(FILE *file, const char *fmt, ...) //eliminate it? 
+void ReturnOutput(FILE *file, const char *fmt, ...) //eliminate it? 
 {
     unsigned long long output_size = 0;
     va_list arg;
 
-    output_buffer = realloc(output_buffer, OUTPUT_MAX);
+    char *output_buffer = malloc(OUTPUT_MAX);
 
     va_start(arg, fmt);
     output_size = vsnprintf(output_buffer, OUTPUT_MAX, fmt, arg);
     va_end(arg);
 
     if(output_size < OUTPUT_MAX){
         output_buffer = realloc(output_buffer, output_size);
+        if (output_buffer == NULL){
+            free(output_buffer);
+        }
     }
 
     //TODO fix this VVV change it to a flag??
@@ -61,7 +64,7 @@ char *ReturnOutput(FILE *file, const char *fmt, ...) //eliminate it?
         fprintf(file ,"%s" ,output_buffer);
     }
 
-    return output_buffer;
+    free(output_buffer);
 }
 
 

diff --git a/src/modules/output.h b/src/modules/output.h
@@ -36,7 +36,7 @@ extern short int  OUTPUT_RETURN;
 
 
 /* FUNCTIONS */
-extern char *ReturnOutput(FILE *file, const char *fmt, ...);
+extern void ReturnOutput(FILE *file, const char *fmt, ...);
 extern void NotFound(FILE *file, const char *term);
 extern void ReturnResults(const long long position, const long long find_count);
 extern void ReturnTotal(FILE *file, const long long find_count);