Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Move secrets to .env file #252

Closed
irsol opened this issue Nov 5, 2019 · 10 comments
Closed

[FEATURE] Move secrets to .env file #252

irsol opened this issue Nov 5, 2019 · 10 comments

Comments

@irsol
Copy link
Collaborator

irsol commented Nov 5, 2019

Describe the solution you'd like
Add secrets to a .env file in the project root folder and add .env to .gitignore file, so it will never be committed. It helps to avoid stealing github and other secrets.

This was referenced Nov 5, 2019
@vinitkumar
Copy link
Owner

@irsol Thanks for reporting this. Let's do the improvements in smaller PRs. It helps in reviewing and ensuring everything still works.

@irsol
Copy link
Collaborator Author

irsol commented Nov 18, 2019

@vinitkumar tests still don't work. I can create a new branch or work in my forked repo and create new pull request from there. Which way would you prefer?

@vinitkumar
Copy link
Owner

vinitkumar commented Nov 18, 2019 via email

@irsol irsol mentioned this issue Nov 27, 2019
@irsol
Copy link
Collaborator Author

irsol commented Nov 27, 2019

@vinitkumar I added all needed env variables to Travis and opened new pull request which will fix all issues with tests. #263

@irsol
Copy link
Collaborator Author

irsol commented Nov 27, 2019

@vinitkumar all tests passed in my branch https://travis-ci.org/irsol/node-twitter/builds/617127398

@vinitkumar
Copy link
Owner

@irsol thanks for the effort. However, looks like you added the env variable in your own fork and not this main upstream travis. Could you please update the env variables and their values here? I will update them to to the project and restart the build. Or you can try setting them directly here (https://travis-ci.org/vinitkumar/node-twitter?utm_medium=notification). Let me know if you are able to do this?

@irsol
Copy link
Collaborator Author

irsol commented Nov 27, 2019

the variables are already there. But I still can not build develop branch.

@vinitkumar
Copy link
Owner

Anyways, I will merge your PR and fix the issues with CI later.

@irsol
Copy link
Collaborator Author

irsol commented Nov 27, 2019

I will also look at the issue.

@irsol
Copy link
Collaborator Author

irsol commented Nov 27, 2019

All tests passed after the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants