Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added necessary space #195

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Added necessary space #195

merged 2 commits into from
Mar 19, 2020

Conversation

goyalmuskan
Copy link
Contributor

Description

Added necessary space around tanks using bootstrap classes.

Fixes #119

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@welcome
Copy link

welcome bot commented Mar 19, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

vinitshahdeo
vinitshahdeo approved these changes Mar 19, 2020
View reviewed changes
Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @goyalmuskan 👏

@vinitshahdeo vinitshahdeo merged commit 8ac01ee into vinitshahdeo:feature/frontend Mar 19, 2020
@welcome
Copy link

welcome bot commented Mar 19, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

@vinitshahdeo vinitshahdeo added easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020 labels Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitshahdeo vinitshahdeo vinitshahdeo approved these changes

Assignees
No one assigned
Labels
easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goyalmuskan @vinitshahdeo