Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landing page design added #196

Closed
wants to merge 1 commit into from

Conversation

FrozenGirl-spd
Copy link

@FrozenGirl-spd FrozenGirl-spd commented Mar 19, 2020

Description

A design for landing page was added.

Fixes #176

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@welcome
Copy link

welcome bot commented Mar 19, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add wireframes or digital designs and explain everything in slight detail.

@amaaniqbal
Copy link

@PragatiVerma18 its also an easy task, so pen and paper are fine.

@FrozenGirl-spd looks good to me, maybe you could slightly update the design to remove some dashboard components and add something informative that represents more of a landing page.

We will create tasks to design the admin dashboard soon, so there you could use such components.

@FrozenGirl-spd
Copy link
Author

Yep! Will update soon,

@amaaniqbal
Copy link

@FrozenGirl-spd any updates?

@FrozenGirl-spd
Copy link
Author

Will update it by today !!

@PragatiVerma18
Copy link
Contributor

@FrozenGirl-spd it's been 10 days and no updates have been added yet. I would have to close this PR if it remains inactive for a longer time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create landing page design [easy] - Instance #10
3 participants