Frontend/react codebase #20
Conversation
|
Thanks for opening this pull request! |
There was a problem hiding this comment.
@jainpawan21 Can you please deploy into Netlify and share the link in PR description?
| body { | ||
| margin: 0; | ||
| background-color: #fafafa; | ||
| font-family: 'Montserrat', sans-serif; |
There was a problem hiding this comment.
@jainpawan21 This font won't load.
Import this font. Check this.
There was a problem hiding this comment.
These fonts are loading perfectly and working fine!
Should I download local fonts?
There was a problem hiding this comment.
I forgot to copy that link. Fixed Now :)
| import {FETCH_TANKS} from './types'; | ||
|
|
||
| export const fetchTanks = () => { | ||
| console.log('in actions') |
There was a problem hiding this comment.
@jainpawan21 Please remove the logs.
react-frontend/src/App.test.js
Outdated
|
|
||
| test('renders learn react link', () => { | ||
| const { getByText } = render(<App />); | ||
| const linkElement = getByText(/learn react/i); |
There was a problem hiding this comment.
@jainpawan21 This test will fail as <App /> doesn't have learn react text anymore. Please update this.
| export default function(state = initialState, action) { | ||
| switch (action.type) { | ||
| case FETCH_TANKS: | ||
| console.log('In reducer') |
There was a problem hiding this comment.
@jainpawan21 Please remove this log.
|
Congrats on merging your first pull request! 🙌🎉⚡️ |
This PR converts main web page into ReactJs. I have used react-redux for state management.
Initial conversion of website into reactt
Please delete options that are not relevant.
Checklist:
Reviewer: Vinit Shahdeo