Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added landing page design as per Instance #8 #201

Merged

Conversation

satvikchachra
Copy link

Description

I have made a landing page design for Water Monitoring System using Adobe XD.

Fixes #174

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@amaaniqbal
Copy link

Please include a corresponding PNG/JPG file for review

@satvikchachra
Copy link
Author

@amaaniqbal Thank you for reviewing my pull request.
Since this is an animated landing page, I have added multiple screenshots in PNG format for review.
Please view it in Adobe XD to view the animation.

@amaaniqbal amaaniqbal merged commit 7efc87c into vinitshahdeo:feature/frontend Mar 21, 2020
@welcome
Copy link

welcome bot commented Mar 21, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

@amaaniqbal
Copy link

Very well done! Looking forward to seeing some more contributions from you ahead :)

@amaaniqbal amaaniqbal added medium medium level issue gssoc20 Welcome to GirlScript Summer of Code 2020 labels Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants