Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Landing Page Design #206

Merged

Conversation

Adyasha8105
Copy link

@Adyasha8105 Adyasha8105 commented Mar 22, 2020

Landing page design is added (using adobe xd and adobe illustrator).
Resolves #175.

@Adyasha8105
Copy link
Author

Adyasha8105 commented Mar 22, 2020

Can you change the level of the task (medium/hard) as I have used so many designing tools?
@amaaniqbal @vinitshahdeo

@amaaniqbal
Copy link

Very well done @Adyasha8105! Just a footer seems to be missing. Try to include that too.

Sure! We will change the label as per your efforts. Don't worry!

@amaaniqbal
Copy link

Also, add your design inside the screenshots/ directory with the instance number. You can see some examples here

@Adyasha8105
Copy link
Author

Adyasha8105 commented Mar 23, 2020

Very well done @Adyasha8105! Just a footer seems to be missing. Try to include that too.

Sure! We will change the label as per your efforts. Don't worry!

Thanks. And I will add the footer also.

@Adyasha8105
Copy link
Author

Also, add your design inside the screenshots/ directory with the instance number. You can see some examples here

Ya, I will do it.

@Adyasha8105
Copy link
Author

@amaaniqbal I have made all those required changes said by you. Can you check it?
And before merging it, Please change the difficulty of the task as you said earlier.

@amaaniqbal
Copy link

I expected a slightly big footer. But this seems fine. Overall the design looks very clear, just that one more section in the design would be better.

I will definitely add a hard label if you can add one more relevant and good-looking section, after about.

@Adyasha8105 Adyasha8105 force-pushed the feature/frontend branch 2 times, most recently from 613070b to 1d8782d Compare March 26, 2020 10:40
@Adyasha8105
Copy link
Author

@amaaniqbal I have done all the required changes said by you.
Can you again check it?

@amaaniqbal
Copy link

I don't think writing something about Open Source programs that we are a part of makes much sense on any landing page. Otherwise. the design looks good to me.
@vinitshahdeo would you like to add something here?

@Adyasha8105
Copy link
Author

Adyasha8105 commented Mar 27, 2020

It is mentioned on the page so I just added it (https://vinitshahdeo.github.io/Water-Monitoring-System/).
So What should I do now @amaaniqbal as I have put a lot of effort into it?

@amaaniqbal
Copy link

Your efforts won't go in vain. Don't worry! :)
If Vinit, doesn't have anything to add here, we will accept it as is. Since we are only looking for design samples to consider while coming up with the final design.

@amaaniqbal amaaniqbal added hard hard level issue gssoc20 Welcome to GirlScript Summer of Code 2020 design design task labels Mar 27, 2020
@Adyasha8105
Copy link
Author

Your efforts won't go in vain. Don't worry! :)
If Vinit, doesn't have anything to add here, we will accept it as is. Since we are only looking for design samples to consider while coming up with the final design.

Okay, @amaaniqbal
I hope @vinitshahdeo will approve this.

@vinitshahdeo
Copy link
Owner

@Adyasha8105 No issues, let's keep it as of now as it's going to be an open-source project and it should be on home page.

Good job @Adyasha8105 👏

CC: @amaaniqbal

@Adyasha8105
Copy link
Author

Adyasha8105 commented Mar 27, 2020

@Adyasha8105 No issues, let's keep it as of now as it's going to be an open-source project and it should be on home page.

Good job @Adyasha8105 👏

CC: @amaaniqbal

Thanks, @vinitshahdeo and @amaaniqbal .

@Adyasha8105
Copy link
Author

@amaaniqbal Can you merge it?

@vinitshahdeo vinitshahdeo merged commit 94543f6 into vinitshahdeo:feature/frontend Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design design task gssoc20 Welcome to GirlScript Summer of Code 2020 hard hard level issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants