Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digital illustration for landing page added #216

Closed

Conversation

FrozenGirl-spd
Copy link

Description

Here is the digital illustration made using Adobe Illustrator.

Fixes #176

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Reviewer: Vinit Shahdeo

@amaaniqbal
Copy link

If you have used Illustrator, then I can increase the difficulty of this task. But before that, I guess you can improve your work. It seems you have used too many colors in your design, some of which looks unnecessary. Try to remove the less significant components and add something relevant instead.

BTW what does the Open Site button signify?

@PragatiVerma18
Copy link
Contributor

@FrozenGirl-spd please do not make a PR to master branch from next time. For design submissions, please push your changes to the feature/documentation branch and include your designs in the Resources folder.

Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use too bright colours for the design and try to keep it simple and elegant. A circular design like this would make it difficult to make the website responsive. So try to visualize the landing page with respect to all the various devices which will be used to access the page.

@FrozenGirl-spd
Copy link
Author

yep.. will submit it today. Sorry..

@FrozenGirl-spd
Copy link
Author

I have pushed the changes to feature/documentation branch...
Can you check it out please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create landing page design [easy] - Instance #10
4 participants