Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting up api #26

Merged
merged 3 commits into from
Feb 28, 2020
Merged

Setting up api #26

merged 3 commits into from
Feb 28, 2020

Conversation

YashMeh
Copy link

@YashMeh YashMeh commented Feb 28, 2020

Description

This PR contains code for setting up the API for the project.

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@welcome
Copy link

welcome bot commented Feb 28, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@auto-assign auto-assign bot requested a review from vinitshahdeo February 28, 2020 06:42
vinitshahdeo
vinitshahdeo approved these changes Feb 28, 2020
View reviewed changes
Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @YashMeh 👏
Thanks.

@vinitshahdeo vinitshahdeo changed the base branch from master to feature/backend-node February 28, 2020 06:48
@vinitshahdeo vinitshahdeo merged commit 93aca8f into vinitshahdeo:feature/backend-node Feb 28, 2020
@welcome
Copy link

welcome bot commented Feb 28, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

@YashMeh YashMeh deleted the setting-up-api branch February 28, 2020 19:30
@jainpawan21 jainpawan21 added easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020 labels Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitshahdeo vinitshahdeo vinitshahdeo approved these changes

Assignees

@vinitshahdeo vinitshahdeo

Labels
easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YashMeh @vinitshahdeo @jainpawan21