Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mentor images now link to proper GitHub accounts #267

Merged
merged 38 commits into from
May 31, 2020

Conversation

pcelis2
Copy link

@pcelis2 pcelis2 commented May 21, 2020

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@welcome
Copy link

welcome bot commented May 21, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@pcelis2
Copy link
Author

pcelis2 commented May 21, 2020

I am sorry if this redundant, I guess last time I did it wrong.

@vinitshahdeo vinitshahdeo changed the base branch from master to feature/documentation May 21, 2020 19:24
@vinitshahdeo
Copy link
Owner

@pcelis2 Please resolve the conflicts.

@PragatiVerma18 PragatiVerma18 merged commit b43a94b into vinitshahdeo:feature/documentation May 31, 2020
@welcome
Copy link

welcome bot commented May 31, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

@PragatiVerma18 PragatiVerma18 added documentation Project Report easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020 labels May 31, 2020
divyabhushan added a commit that referenced this pull request Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Project Report easy Easy issue gssoc20 Welcome to GirlScript Summer of Code 2020
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants