Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making PWA #86

Merged
Merged

Conversation

UddeshJain
Copy link

@UddeshJain UddeshJain commented Mar 2, 2020

Description

Made React Web App a PWA. I have also fixed warnings for centre tag and unique key in src/pages/Home.js

Fixes #40

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UddeshJain Can you please run a UI audit and share the report here?

@UddeshJain
Copy link
Author

UddeshJain commented Mar 2, 2020

@UddeshJain Can you please run a UI audit and share the report here?

Sure @vinitshahdeo . Should I attach an image or pdf document here?

@vinitshahdeo vinitshahdeo added gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue labels Mar 2, 2020
@UddeshJain
Copy link
Author

@vinitshahdeo Please find UI audit report here

@vinitshahdeo
Copy link
Owner

@jainpawan21 Can you please run locally and test the changes once?

@vinitshahdeo
Copy link
Owner

@UddeshJain Can you please deploy your branch using netlify and share the link here?

@UddeshJain
Copy link
Author

@vinitshahdeo Sure.

@UddeshJain
Copy link
Author

@vinitshahdeo I have deployed to netlify. Please take a look here.

Copy link
Owner

@vinitshahdeo vinitshahdeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @UddeshJain 👏

@vinitshahdeo vinitshahdeo changed the title Feature/frontend Making PWA Mar 3, 2020
@jainpawan21 jainpawan21 merged commit f239fa2 into vinitshahdeo:feature/frontend Mar 4, 2020
@welcome
Copy link

welcome bot commented Mar 4, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

@jainpawan21
Copy link

Thanks @UddeshJain, You did an awesome job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants