-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making PWA #86
Making PWA #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@UddeshJain Can you please run a UI audit and share the report here?
Sure @vinitshahdeo . Should I attach an image or pdf document here? |
@vinitshahdeo Please find UI audit report here |
@jainpawan21 Can you please run locally and test the changes once? |
@UddeshJain Can you please deploy your branch using netlify and share the link here? |
@vinitshahdeo Sure. |
@vinitshahdeo I have deployed to netlify. Please take a look here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @UddeshJain 👏
Congrats on merging your first pull request! 🙌🎉⚡️ |
Thanks @UddeshJain, You did an awesome job. |
Description
Made React Web App a PWA. I have also fixed warnings for
centre tag
andunique key
insrc/pages/Home.js
Fixes #40
Type of change
Please delete options that are not relevant.
Checklist:
Reviewer: Vinit Shahdeo