Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure ESLint #277

Open
vinitshahdeo opened this issue Oct 10, 2019 · 12 comments · May be fixed by #389
Open

Configure ESLint #277

vinitshahdeo opened this issue Oct 10, 2019 · 12 comments · May be fixed by #389
Labels
beginner friendly Kick start your Open-Source journey first-timers-only Send your first PR good first issue Good for newcomers hacktoberfest Send PR and earn a free t-shirt help wanted Extra attention is needed up for grabs Solve the issue and raise your first PR

Comments

@vinitshahdeo
Copy link
Owner

Linting is the process of checking the source code for programmatic as well as stylistic errors.

Adding ESLint will be helpful in identifying some common and uncommon mistakes that are made during coding.

ESLint covers both code quality and coding style issues.

  • Add ESLint to this project.
  • Add scripts in package.json i.e. npm run test-lint should run lint tests.
  • Do not make any changes to other files.

Please refer this.
@vinitshahdeo vinitshahdeo added beginner friendly Kick start your Open-Source journey first-timers-only Send your first PR good first issue Good for newcomers hacktoberfest Send PR and earn a free t-shirt help wanted Extra attention is needed up for grabs Solve the issue and raise your first PR labels Oct 10, 2019
@kalpananegi
Copy link

Can I?

@kalpananegi
Copy link

Done please review #279

@vinitshahdeo
Copy link
Owner Author

@kalpananegi Awesome:)

@amarjeetrao
Copy link

amarjeetrao commented Oct 11, 2019 •
edited
Loading

can i take this one?

@vinitshahdeo
Copy link
Owner Author

@amarjeetrao Yes, please go ahead.

@sakshivij
Copy link

Is this issue still not resolved?

@vinitshahdeo
Copy link
Owner Author

@sakshivij Give it a shot. 👍

@coelhucas coelhucas linked a pull request Oct 14, 2019 that will close this issue
Open
@coelhucas
Copy link

I also give a try with #389 :)

@vinitshahdeo
Copy link
Owner Author

@coelhucas Thanks for the PR.
You may look into a few good first issues which are up for grabs.

✅ Link to the repository

@abdulkalam1233
Copy link

#466

@coelhucas check this pull request

wisneycardeal pushed a commit to wisneycardeal/inspirational-quotes that referenced this issue Oct 25, 2019
vinitshahdeo#277 Configure ESLint
1556125 
Adding ESLint on this project.
Adding scripts in package.json to run lint tests.
https://eslint.org/
@wisneycardeal wisneycardeal mentioned this issue Oct 25, 2019
Closed
wisneycardeal pushed a commit to wisneycardeal/inspirational-quotes that referenced this issue Oct 25, 2019
vinitshahdeo#277 Configure ESLint
0ef9181 
Adding ESLint on this project.
Adding scripts in package.json to run lint tests.
https://eslint.org/
@wisneycardeal wisneycardeal mentioned this issue Oct 25, 2019
Open
@ashirbad29
Copy link

is this issue still open, how can i approach this

@ashirbad29
Copy link

#844 @vinitshahdeo checkout this pull request

@BrayanAbraham BrayanAbraham mentioned this issue Oct 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly Kick start your Open-Source journey first-timers-only Send your first PR good first issue Good for newcomers hacktoberfest Send PR and earn a free t-shirt help wanted Extra attention is needed up for grabs Solve the issue and raise your first PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Configure Eslint
7 participants
@sakshivij @vinitshahdeo @coelhucas @amarjeetrao @abdulkalam1233 @ashirbad29 @kalpananegi