Updated for Spree 3.2.0.rc2 and Rails 5 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed failing test rspec ./spec/controllers/spree/orders_controller_decorator_spec.rb:94 # Spree::OrdersController#edit when return to cart when return to cart from cart itself expect to not receive should not receive track_activity(*(any args)) 0 times Changed request.url to request.path to avoid getting get_parameters in next_state comparison -> next_state coming as “cart?id=” instead of “cart” Fixed deprecation warning - use keyword syntax for get, put etc in controller tests Fixed undefined methods for shoulda-matchers like validate_presence_of Refer thoughtbot/shoulda-matchers#951 and https://github.com/thoughtbot/shoulda-matchers#availability-of-matchers-in-various-example-groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed failing test rspec ./spec/controllers/spree/orders_controller_decorator_spec.rb:94 # Spree::OrdersController#edit when return to cart when return to cart from cart itself expect to not receive should not receive track_activity(*(any args)) 0 times
Changed request.url to request.path to avoid getting get_parameters in next_state comparison
-> next_state coming as “cart?id=” instead of “cart”
Fixed deprecation warning - use keyword syntax for get, put etc in controller tests
Fixed undefined methods for shoulda-matchers like validate_presence_of
Refer thoughtbot/shoulda-matchers#951 and https://github.com/thoughtbot/shoulda-matchers#availability-of-matchers-in-various-example-groups