Fix CRC DR read if peripheral clock is disabled #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milosfec
reviewed
Sep 16, 2021
| } | ||
| else | ||
| { | ||
| return 0xFFFFFFFFU; |
There was a problem hiding this comment.
I could have mentioned it in the bug report, we need to invert the result (it's done in the implementation I wrote within the bug report). Function is returning 0xFFFFFFFF because CRC DR returns 0 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #82
Behaviour/ Breaking changes
CRC DR now returns
0xFFFFFFFF0 if the clock is disabled.Other
Fixes a memory leak in the IWDG reset function.
Linked issues: