Demonstration for gimbal based camera #349
Conversation
GilesBathgate
force-pushed
the
gimbal-camera
branch
from
5644ba1
to
39447f7
Compare
|
Sorry I haven't had a chance to look at this yet... lots of projects in the air at the moment :) |
|
@vintagepc Yeah ok. I might do some more work on it anyway, I just didn't want to continue if it's not to your liking. |
|
Is the loss of pan/zoom deliberate or just something that hasn't been implemented yet? I did toy with it a bit and while it does feel a bit more natural in some aspects I'm not sure a complete replacement is ideal for folks already used to the existing camera, and it's probably better to leave a command line option to choose between both control sets. |
| @@ -186,6 +187,12 @@ class MK3SGL: public BasePeripheral, public Scriptable, private IKeyClient | |||
| m_bSDCard = {true}, | |||
| m_bPrintSurface = {true}; | |||
|
|
|||
| float xrotate=0.f; | |||
There was a problem hiding this comment.
Please follow the established variable naming conventions with the appropriate Hungarian notation prefixes.
Just not implemented yet.
Fair enough. I'll create another PR then. |
Description
Demonstrates the gimbal based camera idea I was proposing #347
Try it out with:
./MK404 Prusa_MK3 -g fancyP.S ignore the variable names, I was basing them on printer coordinate system (Z=up) not your viewer coordinate system (y=UP)