Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: pull commits #124

Merged
merged 2 commits into from
Dec 4, 2024
Merged

*: pull commits #124

merged 2 commits into from
Dec 4, 2024

Conversation

GiedriusS
Copy link
Collaborator

  • Remove store pooling as it leads to mem corruption & errors like Error executing query: sum and count timestamps not aligned
  • Add query offset param to help with ingestion delay

@GiedriusS
store: remove putting slices back into pool
0023fc2 
This leads to a race and corruption.

Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
@GiedriusS
rule: add query offset for testing
f151211 
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
@GiedriusS GiedriusS merged commit b442da7 into v0.37.0+vinted Dec 4, 2024
13 of 14 checks passed
@GiedriusS GiedriusS deleted the tweaks_007 branch December 4, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignasr ignasr ignasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GiedriusS @ignasr