Proof of SetHopField #361
Merged
Proof of SetHopField #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcp19
reviewed
Jun 21, 2024
pkg/slayers/path/scion/raw.go
Outdated
| // @ ensures acc(s.Mem(ubuf), R20) | ||
| // @ ensures sl.Bytes(ubuf, 0, len(ubuf)) | ||
| // @ ensures r != nil ==> r.ErrorMem() | ||
| // posts for IO: |
There was a problem hiding this comment.
I'm starting to feel like these "posts for IO" annotations are a bit misleading, mostly because they are not about the IO behaviour, but instead about functional properties of the function. It just so happens that the correctness of the IO behaviour is predicated on the functional correctness of the packet processing. @Dspil would you be ok with us dropping these annotations, or do you think that it will still be useful for you to have the comments here?
jcp19
requested changes
Jun 21, 2024
|
@mlimbeck can you disable moreJoins for |
|
To avoid this bit-rotting, I will now merge it. We can debug the perf. issues later |
jcp19
reviewed
Aug 16, 2024
jcp19
reviewed
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.