Use position IDs as Viper line numbers #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See viperproject/silicon#735 for the explanation of why we don't get multiple verification errors from Silicon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt at #1389.
This PR ensures that Viper positions have unique (line, column) pairs, since Silicon does not use the identifier when deduplicating verification errors from multiple execution paths. Related discussion: viperproject/silicon#732.
The line and column of VIR positions will still refer to the source Rust program, because Prusti uses them to deduplicate counterexamples. Explanation: #1389 (comment). They are then ignored when translating to Viper.
This PR adds a
num_errors_per_functionconfiguration flag to set--numberOfErrorsToReportin Silicon. However, I still can't get more than one error per function. 🤔