This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Support change the rateLimiter of work queue from cli #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwdsuzhou
force-pushed
the
June/expose_ratelimiter
branch
from
e931152
to
a553fa2
Compare
cwdsuzhou
force-pushed
the
June/expose_ratelimiter
branch
from
a553fa2
to
2c994d6
Compare
|
|
cpuguy83
reviewed
Jun 30, 2020
|
|
||
| replace k8s.io/cloud-provider => k8s.io/cloud-provider v0.0.0-20190805144409-8484242760e7 | ||
| replace k8s.io/cloud-provider => k8s.io/cloud-provider v0.17.6 |
There was a problem hiding this comment.
If we update these, I think we can remove these replace statements and put them inline with the main require statement instead.
|
It's timing out for some reason. |
|
Possibly we should |
|
Nope, doesn't help. |
|
Fixed by pre-compiling packages before linting. |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See virtual-kubelet/virtual-kubelet#840
Add rateLimiter to options, so we can use it by
cli.WithBaseOptsping @cpuguy83 for review