Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulation container, navbar, popup menu. Make responsive. #46

Merged
merged 9 commits into from
Aug 11, 2021

Conversation

b30wulffz
Copy link
Collaborator

No description provided.

vjspranav and others added 7 commits June 3, 2021 10:43
* Add versioning support to quiz
* 2.0

* Add support for explanation

* Correct answers based on filter
* TODO: Add filter

* Fix few bugs
* Fixed: Did not render first question of old format
* Fixed: Console log spam if explanation is not provided

* Create dynamically populated filter

* Add functionality to filter
* Fix answers not working after filtering

* Link exp.js
* As both have same contents, let's just link them

* Update json requirement
* Schema to be created

* Generalise difficulty levels

* Also add support for difficulty levels containing space

* Use set range of difficulty levels
* Beginner, Intermediate and Advanced

* Add accordion

* Switch to cheeckboxes

* Don't use trim
* As we have fixed difficulty levels

* Check if user has answered before considering showing examples
* Slightly revamp question iteraions

* Consider question which don't have difficulty level mentioned too

* Make explanations look better
* "Explanation: " in the beginning looks weird

* Condition or correct variable
* version2 script was being used for oldones too

* Continuation to explanation aestathics
* We have them at two places

* Don't scroll up on clicking explanation

* Remove unused css

* Suggested code formatting

* Use Strict
* Fix undeclared vars

* Remove no longer used handlebar helper

Signed-off-by: vjspranav <pranavasri@live.in>

* Use camel ase throughout
* use const where possible

* CamelCase: continuation to previous commit

* Refactor code
* Use forEach where applicable
* Make variables const where possible

* Use bootstrap styling for checkboxes

* [FIXUP] Add eventlistener only to avaialble difficulty levels

* Color only the wrong answer red

* Render html in options too
* https://handlebarsjs.com/guide/expressions.html#html-escaping

* Classify questions as beginner by default
* Questions with no difficulty (or wrong difficulty) will be classified as beginner

* Remove additional logging info

* Remove commented old implememtation of checkbox

* Use proper json variable
* jsonVersion -> isJsonVersion2

* Follow camlCase naming convention`

* Add a small comment referencing the version in script
* Fix padding issue

* Tweaks in padding

* Fix navbar for mobile

* Fix footer, made navbar responsive

* fix spacing in title and sidebar

* Modify toggle sidebar and frame resize, tweak css

* Fix orientation of expanded submenu in navbar
* Added metadata in page template for all experiment pages.

* Code review fixes.
#36)

* Added dummy arguments required for testing env

* Added support for repos starting with tmp

* Revert "Added support for repos starting with tmp"

This reverts commit 0861c9d.

* fixed reference error

* fixed errors

* fixed errors

* fixed more errors

* fixed more errors

* fixed more errors

* fixed more errors

* Added alternate way to get Experiment name

* Added code to convert html encoded experiment name to text

* Disabled conversion of text to uppercase

* Converted college name to uppercase
* Fix padding issue

* Tweaks in padding

* Fix navbar for mobile

* Fix footer, made navbar responsive

* fix spacing in title and sidebar

* Modify toggle sidebar and frame resize, tweak css

* Fix orientation of expanded submenu in navbar

* Revamped navbar menu, made simulation container fullscreen

* Refactor nav-menu items, change var to const
@b30wulffz b30wulffz requested a review from raj-vlabs August 10, 2021 09:38
Copy link
Collaborator

@raj-vlabs raj-vlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the merge conflicts and merge the code.

SRDewan and others added 2 commits August 10, 2021 15:23
* Initial changes for building blugins

* Initial support for plugin with rendering in js

* Interim commit for preBuildPlugins

* Refactor code to move plugin related functionality in a separate class

* Added code for Experiment level processing

* removed unnecessary imports

* Plugin logic.

* Bug fix.

* Debugging.

* Bug fix.

* Bug fix.

* Debugging.

* Bug fix.

* Bug fix.

* Debugging.

* Debugging.

* Debugging.

* Debugging.

* Bug fix.

* Bug fix.

* Bug fix for logo.

* Bug fix in links to exp pages.

* Tools breadcrumbs added.

* Code review fixes.

* Code review fixes.

* Code review fixes.

* Fixed readme title.

* Bug fix.

* Plugins imported as non-repos by removing .git dirs from repos.

* Change to modular approach.

* Removed commented code.

* Code review fixes.

Co-authored-by: vjspranav <pranavasri@live.in>
Co-authored-by: r <raj@vlabs.ac.in>
@b30wulffz b30wulffz requested a review from raj-vlabs August 11, 2021 07:02
@raj-vlabs raj-vlabs merged commit d1b62c6 into master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants