Error toast will be shown while bug reporting #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the issue - #506
raj-vlabs
requested changes
Oct 5, 2024
assets/js/event-handler.js
Outdated
| Toast.fire({ | ||
| icon: 'error', | ||
| iconColor: "white", | ||
| color: "white", | ||
| background: "#f27474", | ||
| timer: 5000, | ||
| title: 'Bug Report Failed, Please Try Again', | ||
| }) | ||
| text: error ? error.message : 'An error occurred while reporting the bug' |
There was a problem hiding this comment.
Showing the user this error message is not useful. You can log it to the console.
In most cases this message is going to be too technical for a general user to understand.
assets/js/event-handler.js
Outdated
| @@ -30,17 +31,19 @@ document.getElementById('bug-report').addEventListener('vl-bug-report', (e) => { | |||
| background: "#a5dc86", | |||
| title: 'Bug Reported Successfully', | |||
| }) | |||
| } else { | |||
| } else { | |||
| const error = event.detail.error; | |||
| Toast.fire({ | |||
| icon: 'error', | |||
| iconColor: "white", | |||
| color: "white", | |||
| background: "#f27474", | |||
| timer: 5000, | |||
| title: 'Bug Report Failed, Please Try Again', | |||
There was a problem hiding this comment.
It's be good to shorten the title and move some of the details into the text section
error message handled well: 1. Logged the technical detailed error 2. Removed unnecessary exposure of the error to the user.
raj-vlabs
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the issue - #506