Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle failed db connection on application startup #877

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

sgfost
Copy link
Contributor

@sgfost sgfost commented Jul 25, 2023

resolves #876

@sgfost sgfost mentioned this pull request Jul 25, 2023
@@ -97,6 +97,7 @@
"node-schedule": "^1.3.2",
"nodemailer": "^6.6.0",
"nodemailer-mailgun-transport": "^2.1.3",
"p-retry": "4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the latest version 5 problematic or have other dependency issues?

https://www.npmjs.com/package/p-retry?activeTab=versions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd need to switch to ESM in node. From the author: https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

Seems like something we should do but I still need to look into it more

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, thanks! Transitioning to ESM seems like something worth doing at some point but no need to hold this up.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some looking into it and it still seems like a bit of a dumpster fire that I wouldn't want to touch just yet. The previous versions of these packages that have gone pure ESM seem stable enough to still make up 98% of npm downloads so we have some time

@alee alee merged commit 08e86cf into virtualcommons:main Jul 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add server healthcheck
2 participants