Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: replace webpack/vue-cli with vite #891

Merged
merged 3 commits into from
Sep 23, 2023
Merged

Conversation

sgfost
Copy link
Contributor

@sgfost sgfost commented Sep 21, 2023

seems to be working after messing with vite config enough and removing
requires

still more to rip out (jest, etc.) and tsconfig/linting needs to be
fixed

[no ci]
@sgfost sgfost added client Client Side dependencies Pull requests that update a dependency file labels Sep 21, 2023
pinned sass to 1.64 so it doesnt complain about deprecated stuff in
bootstrap 4 which we cant really upgrade from anytime soon

remove/move around some other deps
@sgfost
Copy link
Contributor Author

sgfost commented Sep 21, 2023

good opportunity to revist code splitting but everything seems to be working now

@sgfost sgfost marked this pull request as ready for review September 21, 2023 23:31
@sgfost sgfost changed the title build (experimental): switch to vue 2.7 and vite Build: replace webpack/vue-cli with vite Sep 21, 2023
Copy link
Member

@alee alee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this worked perfectly on my mac (with hot reloading etc) but on my linux box it brought up these errors

 ❯ doc logs -f client                                                                                                                                                                                                       [13:37:00] 
port-of-mars-client-1  | yarn run v1.22.19                                                                                                                                                                                             
port-of-mars-client-1  | $ vite                                                                                                                                                                                                        
port-of-mars-client-1  | /bin/sh: 1: vite: not found                                                                                                                                                                                   
port-of-mars-client-1  | error Command failed with exit code 127.                                                                                                                                                                      
port-of-mars-client-1  | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.                                                                                                                          
port-of-mars-client-1  | yarn run v1.22.19                                                                                                                                                                                             
port-of-mars-client-1  | $ vite                                                                                                                                                                                                        
port-of-mars-client-1  | /bin/sh: 1: vite: not found                                                                                                                                                                                   
port-of-mars-client-1  | error Command failed with exit code 127.                                                                                                                                                                      
port-of-mars-client-1  | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.                                                                                                                          
port-of-mars-client-1  | yarn run v1.22.19                                                                                                                                                                                             
port-of-mars-client-1  | $ vite       
...

might be something I have to clean up on my local filesystem? I removed an old (2022) client/node_modules directory and also tried running on a completely fresh checkout also but with the same results

@sgfost
Copy link
Contributor Author

sgfost commented Sep 22, 2023

docker cache maybe?

@sgfost sgfost merged commit 5efea60 into virtualcommons:main Sep 23, 2023
3 checks passed
@alee
Copy link
Member

alee commented Sep 23, 2023

seems like it, running docker system prune -a and rebuilding fixed the issue on linux. maybe there's a volume with cached node_modules that's not getting cleaned out properly on rebuild?

I'll try to look into it when I get a chance but if anyone else figures it out first please go for it

@sgfost
Copy link
Contributor Author

sgfost commented Sep 29, 2023

docker compose build --no-cache works as well, not sure how to make it invalidate the layer cache otherwise, but probably a non-issue at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Client Side dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

try to replace webpack with vite
2 participants