-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: replace webpack/vue-cli with vite #891
Conversation
seems to be working after messing with vite config enough and removing requires still more to rip out (jest, etc.) and tsconfig/linting needs to be fixed [no ci]
pinned sass to 1.64 so it doesnt complain about deprecated stuff in bootstrap 4 which we cant really upgrade from anytime soon remove/move around some other deps
good opportunity to revist code splitting but everything seems to be working now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this worked perfectly on my mac (with hot reloading etc) but on my linux box it brought up these errors
❯ doc logs -f client [13:37:00]
port-of-mars-client-1 | yarn run v1.22.19
port-of-mars-client-1 | $ vite
port-of-mars-client-1 | /bin/sh: 1: vite: not found
port-of-mars-client-1 | error Command failed with exit code 127.
port-of-mars-client-1 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
port-of-mars-client-1 | yarn run v1.22.19
port-of-mars-client-1 | $ vite
port-of-mars-client-1 | /bin/sh: 1: vite: not found
port-of-mars-client-1 | error Command failed with exit code 127.
port-of-mars-client-1 | info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
port-of-mars-client-1 | yarn run v1.22.19
port-of-mars-client-1 | $ vite
...
might be something I have to clean up on my local filesystem? I removed an old (2022) client/node_modules
directory and also tried running on a completely fresh checkout also but with the same results
docker cache maybe? |
seems like it, running I'll try to look into it when I get a chance but if anyone else figures it out first please go for it |
|
upgrade to vue 2.7
remove vue-cli/webpack stuff and replace with vite + vite-plugin-vue2
jest setup on the client is replaced with vitest
resolves try to replace webpack with vite #890