Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build on Node 6 & 7 #242

Merged
merged 1 commit into from
Nov 30, 2016
Merged

Build on Node 6 & 7 #242

merged 1 commit into from
Nov 30, 2016

Conversation

balthazar
Copy link
Contributor

Travis now test the project using the Node 6 LTS version and the latest 7, so we can have better vision of our current support and future possible issues coming in a next update.

@balthazar balthazar added the test label Nov 30, 2016
@ibgreen
Copy link
Collaborator

ibgreen commented Nov 30, 2016

Thanks!

  • Should we use the "engines" field in package.json to specify these versions?
  • Should we mention our preference in README.md?

@ibgreen ibgreen merged commit 430e1e3 into master Nov 30, 2016
@ibgreen ibgreen deleted the update-node branch November 30, 2016 23:16
@balthazar
Copy link
Contributor Author

Don't think we should use engines, as it's only advisory (they deprecated engineStrict), and this would also be used upon simple install I believe.

We can add a small statement in the Node version requirement section indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ibgreen ibgreen

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@balthazar @ibgreen