Added new numSegments prop in ArcLayer #8055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
reviewed
Aug 16, 2023
felixpalmer
requested changes
Aug 21, 2023
felixpalmer
approved these changes
Aug 22, 2023
Pessimistress
changed the title
Pessimistress
pushed a commit
that referenced
this pull request
Aug 29, 2023
Pessimistress
pushed a commit
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8052
Background
Added a new parameter to be able to modify the number of segments used to generate arcs. Previously the number was hardcoded - 50.
This will allow rendering smooth arcs in case of long paths with
greatCircleparam.Change List
numSegmentsprop inArcLayer