CARTO: Don't hardcode mime-types #8076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pessimistress
pushed a commit
that referenced
this pull request
Aug 24, 2023
felixpalmer
added a commit
that referenced
this pull request
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #8056
Background
The old versions of the CARTO API did not set explicit mime-types for responses. Both the vector and spatial index binary format simply returned
Content-Type: application/x-protobufwhich meant loaders.gl has no way to select a loader automatically. As of v=3.2 the API returns explicit mimeTypes so loaders.gl can automatically select the correct loader without having to be informed explictly vialoadOptionsChange List