[mapbox] Fix interleaving when base map has terrain #8111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mapbox issue: mapbox/mapbox-gl-js#12888 |
Pessimistress
added a commit
that referenced
this pull request
Sep 13, 2023
Pessimistress
added a commit
that referenced
this pull request
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8060
Background
The current projection matrix parameters in WebMercatorViewport are designed to match an early release of Mapbox. Between mapbox-gl, maplibre-gl, and their different major versions, the calculation has diverged significantly. This hack extracts near and far plane positions from a private property on the mapbox-gl map.
For the long term, I will open feature requests for the base maps to expose their projection matrix.
Change List