Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary attribute support #8153

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Binary attribute support #8153

merged 5 commits into from
Oct 3, 2023

Conversation

Pessimistress
Copy link
Collaborator

For #8152

Change List

  • Bump luma.gl version for Fix model.setBufferLayout luma.gl#1816
  • Attribute class exposes a layoutChanged flag
  • Layer.updateAttributes update model buffer layouts if necessary
  • Refactor SolidPolygonLayer shaders to avoid attributes that are not set via geometry or attribute manager
  • Restore render tests for binary attributes and MVTLayer
  • Update examples/experimental/interleaved-buffer app to v9 API

@Pessimistress Pessimistress merged commit fb951e7 into master Oct 3, 2023
2 checks passed
@Pessimistress Pessimistress deleted the x/binary-attributes branch October 3, 2023 18:41
@felixpalmer felixpalmer mentioned this pull request Oct 12, 2023
Closed
14 tasks
This was referenced Nov 2, 2023
Merged
Merged
@Pessimistress Pessimistress mentioned this pull request Mar 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixpalmer felixpalmer felixpalmer approved these changes

@ibgreen ibgreen ibgreen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pessimistress @felixpalmer @ibgreen