chore: Upgrade v8.10 to math.gl@4.0.0. Remove gl-matrix #8200
Conversation
ibgreen
changed the title
ibgreen
changed the title
| @@ -22,7 +22,7 @@ import TEST_CASES from './test-cases'; | |||
| import {WIDTH, HEIGHT} from './constants'; | |||
| import {SnapshotTestRunner} from '@deck.gl/test-utils'; | |||
|
|
|||
| import './jupyter-widget'; | |||
| // import './jupyter-widget'; | |||
There was a problem hiding this comment.
As far as I can tell, math.gl 4.0 breaks jupyter-widget tests. The tests just freeze, I haven't figured out how to proceed with debugging
There was a problem hiding this comment.
Please add a TODO comment.
There was a problem hiding this comment.
The good news is that these tests seem to work again on 9.0, so it is presumably related to ES / CJS incompatibility causing some problems for Jupyter on 8.10.
We may need to make a decision on whether we can land this on 8.10 and temporarily break jupyter support). Since 8.10 is only dev releases and not for production this may be acceptable.
(I understand there is a new 8.0 python widgets library, maybe it addresses some of these things.)
|
Why are we bumping major dependency versions in a minor release? luma.gl is still depending on older math. |
| "@math.gl/web-mercator": "^4.0.0", | ||
| "@math.gl/culling": "^4.0.0", | ||
| "@math.gl/geospatial": "^4.0.0", | ||
| "@math.gl/proj4": "^4.0.0", |
There was a problem hiding this comment.
These are not going to help end users.
loaders.gl is needed and is bringing in math.gl 4.0 anyways.
Yes. I was experimenting with making an 8.6 or 8.10 release of luma.gl to bump math.gl but the publish scripts are broken on my machine. We can try to leave math.gl untouched on 8.10 for now and see if things work well with loaders.gl 4.0. |
Background
Change List