Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node 18 #8222

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Use node 18 #8222

merged 2 commits into from
Oct 25, 2023

Conversation

chrisgervang
Copy link
Collaborator

@chrisgervang chrisgervang commented Oct 23, 2023

Background

Node 18.18.2 is now LTS. Discussion started in #8220

Change List

  • Use node 18 in github actions and volta

@chrisgervang chrisgervang marked this pull request as ready for review October 23, 2023 21:35
@birkskyum
Copy link
Contributor

Node is moving pretty fast - v20 is the active LTS now.
Screenshot 2023-10-24 at 23 37 02

@ibgreen
Copy link
Collaborator

ibgreen commented Oct 24, 2023

yeah. A bit too fast sometimes :) not all npm modules are able to catch up so while being on the latest sounds appealing one can run into some unwelcome surprises.

As an example we are just able to get loaders.gl upgraded to 18&20 now in the 4.0 release. That was a lot of work. hopefully it will be much less going forward.

@ibgreen ibgreen merged commit 0356f75 into master Oct 25, 2023
2 checks passed
@ibgreen ibgreen deleted the chr/node-18 branch October 25, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants