Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CARTO: v9 don't mutate object from request cache #8238

Merged
merged 6 commits into from
Nov 7, 2023
Merged

CARTO: v9 don't mutate object from request cache #8238

merged 6 commits into from
Nov 7, 2023

Conversation

felixpalmer
Copy link
Collaborator

For #8148

The destructing of the tilejson object in baseSource meant that the data prop was changing on every frame

Change List

  • Make request cache include the accessToken to avoid mutating object in baseSource

@felixpalmer felixpalmer merged commit 9a8d02a into master Nov 7, 2023
2 checks passed
@felixpalmer felixpalmer deleted the felix/carto-request-token branch November 7, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alasarr alasarr alasarr approved these changes

@mdeividas mdeividas mdeividas approved these changes

@zbigg zbigg Awaiting requested review from zbigg

@padawannn padawannn Awaiting requested review from padawannn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixpalmer @alasarr @mdeividas